Use installation package for directory determination. #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/dx-1699
branch
2 times, most recently
from
3fb5ce7 to
bee8717
Compare
mitchell-as
force-pushed
the
mitchell/dx-1699
branch
from
bee8717 to
c586708
Compare
MDrakos
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I searched the codebase for all uses of the
installation.*Exec()methods and looked to see if they usedfilepath.Dir()or other filepath manipulations to produce some path that could be produced by any of theinstallation.*()methods and found none. This appeared to be a one-off due to my ignorance.