Initial implementation of state export log.
#2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Nov 20, 2023
•
mitchell-as
commented
 DX-1593 Access logs without specifying PID
|
mitchell-as
force-pushed
the
mitchell/dx-1593
branch
from
e17f191 to
528f218
Compare
mitchell-as
force-pushed
the
mitchell/dx-1593
branch
from
528f218 to
ebf0a4b
Compare
MDrakos
requested changes
Nov 21, 2023
| } | ||
| for _, file := range logFiles { | ||
| if regex.MatchString(file) { | ||
| timestamp, err := strconv.Atoi(regex.FindStringSubmatch(file)[1]) |
There was a problem hiding this comment.
Does the regex.MatchString guarantee that we will find a second group? If not the indexing of the slice here is a potential panic.
There was a problem hiding this comment.
Yes, if there is a match, the capture from the pattern guarantees a valid index.
MDrakos
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.