Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DNS errors input errors to inform the user something is wrong with their network. #2870

Closed
wants to merge 1 commit into from
Closed

Make DNS errors input errors to inform the user something is wrong with their network. #2870

wants to merge 1 commit into from

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Nov 7, 2023 •
edited by github-actions bot
Loading

BugDX-2269 state init fails to setup runtime

@mitchell-as mitchell-as requested a review from MDrakos November 7, 2023 16:48
@mitchell-as mitchell-as marked this pull request as ready for review November 7, 2023 16:48
MDrakos
MDrakos reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that input errors only affect the reporting to rollbar, not the user. Am I wrong?

@mitchell-as
Copy link
Contributor Author

mitchell-as commented Nov 8, 2023 •
edited
Loading

You are correct. I thought for some reason that input errors would be surfaced to the user (taking priority over errs.Wrap() and locale.WrapError() errors). After some experimentation I found this was not the case, so I made some comments to the original ticket and punted it back to triage.

Thanks for catching this.

@mitchell-as mitchell-as closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos