Added commitID for activation tests that immediately run state pull to update.
#2862
Conversation
|
The failure here is intermittent and not related to this PR. |
| @@ -423,6 +423,7 @@ version: %s | |||
| `, constants.BranchName, constants.Version)) | |||
|
|
|||
| ts.PrepareActiveStateYAML(content) | |||
| ts.PrepareCommitIdFile("59404293-e5a9-4fd0-8843-77cd4761b5b5") | |||
There was a problem hiding this comment.
Shouldn't the commit ID file be disabled for v43? Sorry if I'm missing something here...
There was a problem hiding this comment.
That function body will have a temporary shim to handle legacy vs. commit ID file. At this time since that PR is not merged yet, we're still using commit ID files.
There was a problem hiding this comment.
Does this change now that the PR is removed?
There was a problem hiding this comment.
The function ends up modifying the activestate.yaml to the project: org/project#commitId format instead of creating a commit file. Whenever we end up putting localcommits and buildscripts back, that function will go back to writing commit files instead of modifying activestate.yaml.
Either way is transparent to the test and the test should not care what happens behind the scenes.
The commitID doesn't matter, but it ought to be specified. Projects without commitIDs don't exist in the real world as far as I can tell.