Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed offline installer from the repo. #2854

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Removed offline installer from the repo. #2854

merged 1 commit into from
Oct 30, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 30, 2023 •
edited by github-actions bot
Loading

TaskDX-2160 Remove offline installer from cli repo

It exists as a separate repository now.

@mitchell-as
Removed offline installer from the repo.
d42e4e2 
It exists as a separate repository now.
@mitchell-as
Copy link
Contributor Author

Tests are here: https://github.com/ActiveState/cli/actions/runs/6697164730. The lone Linux failure is sporadic and unrelated to this PR.

@mitchell-as mitchell-as requested a review from MDrakos October 30, 2023 18:53
@mitchell-as mitchell-as marked this pull request as ready for review October 30, 2023 18:53
MDrakos
MDrakos approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much deleted code
image

@mitchell-as mitchell-as reopened this Oct 30, 2023
@mitchell-as mitchell-as merged commit 6b70818 into version/0-43-0-RC1 Oct 30, 2023
14 of 19 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2160 branch October 30, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos