Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SetupRCFile failing because no rc file exists in home dir #2836

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix SetupRCFile failing because no rc file exists in home dir #2836

merged 1 commit into from
Oct 20, 2023

Conversation

Naatan
Copy link
Member

@Naatan Naatan commented Oct 20, 2023 •
edited by github-actions bot
Loading

BugDX-2292 Nightly failures: os.Open .bashrc failed

@github-actions github-actions bot changed the base branch from master to version/0-42-0-RC1 October 20, 2023 18:21
@Naatan Naatan requested a review from mitchell-as October 20, 2023 19:18
mitchell-as
mitchell-as approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@mitchell-as mitchell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like PRs that remove more code than they add. Nice job.

@Naatan Naatan merged commit c4ca306 into version/0-42-0-RC1 Oct 20, 2023
11 of 28 checks passed
@Naatan Naatan deleted the DX-2292 branch October 20, 2023 19:25
as-builds added a commit that referenced this pull request Oct 20, 2023
@as-builds
Merge branch version/0-42-0-RC1 to adopt changes from PR #2836
ae590d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell-as mitchell-as mitchell-as approved these changes

Assignees
No one assigned
Labels
Test: deploy Test: installer Test: shell Test: use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naatan @mitchell-as