Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update failure analytics events should set target version, not version. #2747

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Update failure analytics events should set target version, not version. #2747

merged 2 commits into from
Sep 11, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Sep 11, 2023 •
edited by github-actions bot
Loading

BugDX-2144 Update events incorrectly setting the target_version

@mitchell-as mitchell-as requested a review from Naatan September 11, 2023 21:44
@mitchell-as mitchell-as marked this pull request as ready for review September 11, 2023 21:44
Naatan
Naatan requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you missed two; lines 112 and 119.

@mitchell-as
Copy link
Contributor Author

Thanks for pointing those out.

@mitchell-as mitchell-as requested a review from Naatan September 11, 2023 21:49
@mitchell-as mitchell-as merged commit 4db4b1f into version/0-41-0-RC1 Sep 11, 2023
6 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2144 branch September 11, 2023 22:14
as-builds added a commit that referenced this pull request Sep 11, 2023
@as-builds
Merge branch version/0-41-0-RC1 to adopt changes from PR #2747
ce4965d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naatan Naatan Naatan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @Naatan