Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process PlanningError build plan types as errors. #2743

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Process PlanningError build plan types as errors. #2743

merged 1 commit into from
Sep 11, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Sep 11, 2023 •
edited by github-actions bot
Loading

BugDX-2183 Failed Build error is not marked as input error

Not all of these types have non-nil Error fields.

@mitchell-as
Process PlanningError build plan types as errors.
c92a964 
Not all of these types have non-nil Error fields.
@mitchell-as mitchell-as requested a review from MDrakos September 11, 2023 17:39
@mitchell-as mitchell-as marked this pull request as ready for review September 11, 2023 17:39
MDrakos
MDrakos approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense but have we confirmed it addresses the issue in the story?

@mitchell-as
Copy link
Contributor Author

Yes, I stepped through it with a debugger both before and after. The fix is legit.

@mitchell-as mitchell-as merged commit 3647572 into version/0-41-0-RC1 Sep 11, 2023
8 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2183 branch September 11, 2023 22:27
as-builds added a commit that referenced this pull request Sep 11, 2023
@as-builds
Merge branch version/0-41-0-RC1 to adopt changes from PR #2743
7ca79be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos