Skip to content

Commit

Permalink
Merge branch version/0-43-0-RC1 to adopt changes from PR #2940
Browse files Browse the repository at this point in the history
  • Loading branch information
as-builds committed Dec 13, 2023
2 parents 59b0198 + 285fb93 commit db6ce57
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions internal/runners/clean/run_win.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,14 @@ func removeInstall(logFile string, params *UninstallParams, cfg *config.Instance
return locale.WrapError(err, "err_state_exec")
}

// Schedule removal of the entire branch name directory.
// Schedule removal of the entire install directory.
// This is because Windows often thinks the installation.InstallDirMarker and
// constants.StateInstallerCmd files are still in use.
branchDir := filepath.Dir(filepath.Dir(stateExec))
paths := []string{stateExec, branchDir}
installDir, err := installation.InstallPathFromExecPath()
if err != nil {
return errs.Wrap(err, "Could not get installation path")
}
paths := []string{stateExec, installDir}
if params.All {
paths = append(paths, cfg.ConfigPath()) // also remove the config directory
}
Expand Down

0 comments on commit db6ce57

Please sign in to comment.