Merge pull request #2936 from ActiveState/mitchell/dx-2353

When determining the current project, prefer the activated project before anything else.
ActiveState · Dec 7, 2023 · 26b7b08 · 26b7b08
2 parents b51523c + 71785d6
commit 26b7b08
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/pkg/projectfile/projectfile.go b/pkg/projectfile/projectfile.go
@@ -779,13 +779,21 @@ func GetProjectFilePath() (string, error) {
 }
 
 func getProjectFilePathFromEnv() (string, error) {
-	projectFilePath := os.Getenv(constants.ProjectEnvVarName)
+	var projectFilePath string
+
+	if activatedProjectDirPath := os.Getenv(constants.ActivatedStateEnvVarName); activatedProjectDirPath != "" {
+		projectFilePath = filepath.Join(activatedProjectDirPath, constants.ConfigFileName)
+	} else {
+		projectFilePath = os.Getenv(constants.ProjectEnvVarName)
+	}
+
 	if projectFilePath != "" {
 		if fileutils.FileExists(projectFilePath) {
 			return projectFilePath, nil
 		}
 		return "", &ErrorNoProjectFromEnv{locale.NewInputError("err_project_env_file_not_exist", "", projectFilePath)}
 	}
+
 	return "", nil
 }
 

diff --git a/pkg/projectfile/projectfile_test.go b/pkg/projectfile/projectfile_test.go
@@ -222,6 +222,7 @@ func TestGetProjectFilePath(t *testing.T) {
 	require.Nil(t, err)
 	expectedPath := filepath.Join(root, "pkg", "projectfile", "testdata", constants.ConfigFileName)
 	assert.Equal(t, expectedPath, configPath, "Project path is properly detected")
+	os.Chdir(cwd) // restore
 
 	defer os.Unsetenv(constants.ProjectEnvVarName)
 
@@ -251,6 +252,14 @@ func TestGetProjectFilePath(t *testing.T) {
 	configPath, err = GetProjectFilePath()
 	assert.NoError(t, err, "GetProjectFilePath should succeed")
 	assert.Equal(t, expectedPath, configPath, "Project path is properly detected using default path from config")
+
+	// The activestate.yaml for an activated project should be used no matter what.
+	defer os.Unsetenv(constants.ActivatedStateEnvVarName)
+	os.Setenv(constants.ActivatedStateEnvVarName, filepath.Dir(expectedPath))
+	configPath, err = GetProjectFilePath()
+	require.Nil(t, err)
+	assert.Equal(t, expectedPath, configPath, "Project path is properly detected using the ActivatedStateEnvVarName")
+	os.Unsetenv(constants.ActivatedStateEnvVarName)
 }
 
 // TestGet the config