Skip to content

Commit

Permalink
Don't use custom target dir
Browse files Browse the repository at this point in the history
  • Loading branch information
MDrakos committed Oct 10, 2023
1 parent 12c87d4 commit 12a1234
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions test/integration/install_scripts_int_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ func (suite *InstallScriptsIntegrationTestSuite) TestInstall() {
suite.Require().NoError(fileutils.WriteFile(script, b))

// Construct installer command to execute.
installDir := filepath.Join(ts.Dirs.HomeDir, "install")
argsPlain := []string{script, "-t", installDir}
// installDir := filepath.Join(ts.Dirs.Work, "install")
argsPlain := []string{script}
if tt.Channel != "" {
argsPlain = append(argsPlain, "-b", tt.Channel)
}
Expand Down Expand Up @@ -130,12 +130,16 @@ func (suite *InstallScriptsIntegrationTestSuite) TestInstall() {

cp.ExpectExitCode(0)

stateExec, err := installation.StateExecFromDir(installDir)
stateExec, err := installation.StateExecFromDir(ts.Dirs.HomeDir)
suite.NoError(err)
suite.FileExists(stateExec)

suite.assertBinDirContents(filepath.Join(installDir, "bin"))
suite.assertCorrectVersion(ts, installDir, tt.Version, tt.Channel)
installPath, err := installation.InstallPathForBranch(constants.BranchName)
suite.NoError(err)

binPath := filepath.Join(installPath, "bin")
suite.assertBinDirContents(binPath)
suite.assertCorrectVersion(ts, binPath, tt.Version, tt.Channel)
suite.DirExists(ts.Dirs.Config)

// Verify that can install overtop
Expand Down

0 comments on commit 12a1234

Please sign in to comment.