Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to build harmony #1

Open
tianyizhangcs opened this issue Jul 12, 2018 · 4 comments
Open

failed to build harmony #1

tianyizhangcs opened this issue Jul 12, 2018 · 4 comments
Assignees

Comments

@tianyizhangcs
Copy link

Error message when building with gcc 7.3:

code_generator.cxx: In function ‘int parse_slave_list(const char*)’:
code_generator.cxx:577:40: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         while (head < tail && (head == '\0' || isspace(*head))) {
                                        ^~~~
code_generator.cxx:583:40: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         while (head < tail && (head != '\0' && !isspace(*head))) {
                                        ^~~~
code_generator.cxx:599:40: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         while (head < tail && (head == '\0' || isspace(*head))) {
@rchyena rchyena self-assigned this Jul 13, 2018
rchyena added a commit that referenced this issue Jul 13, 2018
Pointer was not dereferenced prior to comparison.

This closes #1.
rchyena added a commit that referenced this issue Jul 13, 2018
Pointer was not dereferenced prior to comparison.

This closes #1.
@rchyena
Copy link
Member

rchyena commented Jul 13, 2018

I've pushed a fix for this. It will be incorporated with the next release. Until then, you can use the hotfix-v4.6.0 branch to avoid the compilation error.

@ghost
Copy link

ghost commented Oct 29, 2020

I get the same error when I try to build active harmony independently as well as from TAU (with APEX)

@rchyena
Copy link
Member

rchyena commented Oct 29, 2020

What branch were you using when you got this error? I believe it is fixed on hotfix-v4.6.0.

@ghost
Copy link

ghost commented Oct 30, 2020

It built successfully on hotfix-v4.6.0 branch. I'm sorry, I assumed that the changes would have been incorporated into the master branch. Thank you for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants