Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to retry when data reception stops from the server? #11

Open
naa0yama opened this issue Nov 4, 2023 · 3 comments
Open
Assignees
Labels
bug Something isn't working in progress New feature being implemented

Comments

@naa0yama
Copy link

naa0yama commented Nov 4, 2023

Hi,

I'm using it because I want to organize my library.
First of all, thank you for releasing this product, it's a big help as it's hard to download hundreds of libraries.
I'd like to report some strange behavior there.

Report

For example this.
https://www.dlsite.com/maniax/work/=/product_id/RJ01038977.html

It's a nice design that when there are multiple "contents", they are downloaded in order, but there are times when the data reception from the DLSite server is interrupted and the download may not be completed to the end.

With this tool that you have published separately, I was able to set the Timeout in "requests" to have it retry when data reception stops, but I have never written Rust, so I would like to report it. Become. . Can this be retried?

https://github.com/AcrylicShrimp/dlsite-downloader

Version

1.5.0

@AcrylicShrimp
Copy link
Owner

Thank for this kind report! I already implemented retrying behaviour but it seems that it's not working properly. Let me investigate this issue. I'll fix it and ship in next release.

@naa0yama
Copy link
Author

naa0yama commented Nov 4, 2023

Thank you. I'm looking forward to the next release.

PS; I think it would be great if in the future I could put libraries in a download queue and download them in order (I'm getting tired of pressing the button 700 times right now lol.

@AcrylicShrimp
Copy link
Owner

Aha, yes. I'll add that feature too.

@AcrylicShrimp AcrylicShrimp added in progress New feature being implemented bug Something isn't working labels Mar 2, 2024
@AcrylicShrimp AcrylicShrimp self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress New feature being implemented
Projects
None yet
Development

No branches or pull requests

2 participants