Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration to karura. #1365

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Add migration to karura. #1365

merged 3 commits into from
Aug 26, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented Aug 26, 2021

(paritytech/substrate#9197) Migrate pallet-treasury to the new pallet attribute macro

  • Karura uses Treasury as module name so there is not need to migrate.

(paritytech/substrate#9165) Move PalletVersion away from the crate version

  • Migration needed.

Closes #1332

@shaunxw shaunxw requested a review from xlc August 26, 2021 01:49
xlc
xlc requested changes Aug 26, 2021
View reviewed changes
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acala/runtime/karura/src/lib.rs

Lines 1766 to 1767 in 518a7b7

pub type Executive =
frame_executive::Executive<Runtime, Block, frame_system::ChainContext<Runtime>, Runtime, AllPallets, ()>;

Need to replace () to OnRuntimeUpgrade and confirm it works with try-runtime

@shaunxw
Copy link
Contributor Author

shaunxw commented Aug 26, 2021

Just run all try runtime tests on latest block(Block#409649), the logs are as follows:

cargo run --features with-mandala-runtime --features try-runtime -- try-runtime --wasm-execution=compiled --block-at=0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56 --url="wss://karura.api.onfinality.io/public-ws" on-runtime-upgrade live -s snapshot.bin
   Compiling acala-cli v1.3.1 (/home/shaun/Projects/acala/node/cli)
   Compiling acala-service v1.3.1 (/home/shaun/Projects/acala/node/service)
   Compiling acala v1.3.1 (/home/shaun/Projects/acala/node)
    Finished dev [unoptimized + debuginfo] target(s) in 40.25s
     Running `target/debug/acala try-runtime --wasm-execution=compiled --block-at=0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56 '--url=wss://karura.api.onfinality.io/public-ws' on-runtime-upgrade live -s snapshot.bin`
2021-08-26 19:32:09.337  INFO main remote-ext: initializing remote client to "wss://karura.api.onfinality.io/public-ws"    
2021-08-26 19:32:10.171  INFO main remote-ext: scraping key-pairs from remote @ 0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56    
2021-08-26 19:32:10.171  INFO main remote-ext: downloading data for all modules.    
2021-08-26 19:35:17.986  INFO main remote-ext: Querying a total of 103850 keys    
2021-08-26 19:38:21.267  INFO main remote-ext: writing to state snapshot file "snapshot.bin"    
2021-08-26 19:38:21.314  INFO main remote-ext: extending externalities with 1 manually injected key-values    
2021-08-26 19:38:21.315  INFO main remote-ext: injecting a total of 103852 keys    
2021-08-26 19:38:59.750  INFO main runtime::frame-support: ⚠️ System declares internal migrations (which *might* execute). On-chain `<wasm:stripped>` vs current storage version `<wasm:stripped>`    
2021-08-26 19:38:59.750  INFO main runtime::frame-support: ✅ no migration for Sudo    
2021-08-26 19:38:59.750  INFO main runtime::frame-support: ✅ no migration for SessionManager    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for AuraExt    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for Aura    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for Session    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for CollatorSelection    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for Authorship    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for EvmManager    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for EvmAccounts    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for EVMBridge    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for EVM    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for OrmlXcm    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for UnknownTokens    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for XTokens    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for DmpQueue    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for CumulusXcm    
2021-08-26 19:38:59.751  INFO main runtime::frame-support: ✅ no migration for PolkadotXcm    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for XcmpQueue    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for ParachainInfo    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for ParachainSystem    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for CompoundCash    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for Starport    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for ChainSafeTransfer    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for ChainBridge    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for RenVmBridge    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for AirDrop    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for NFT    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for Incentives    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for HomaLite    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for HomaValidatorListModule    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for PolkadotBridge    
2021-08-26 19:38:59.752  INFO main runtime::frame-support: ✅ no migration for StakingPool    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for NomineesElection    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for Homa    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for EmergencyShutdown    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for CdpEngine    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for CdpTreasury    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for Honzon    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for Loans    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for AuctionManager    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for Dex    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for Prices    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for OrmlNFT    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for Rewards    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for Auction    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for OperatorMembershipBand    
2021-08-26 19:38:59.753  INFO main runtime::frame-support: ✅ no migration for BandOracle    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for OperatorMembershipAcala    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for AcalaOracle    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for Democracy    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for PhragmenElection    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for Authority    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for TechnicalCommitteeMembership    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for TechnicalCommittee    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for HomaCouncilMembership    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for HomaCouncil    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for FinancialCouncilMembership    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for FinancialCouncil    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for GeneralCouncilMembership    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for GeneralCouncil    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for GraduallyUpdate    
2021-08-26 19:38:59.754  INFO main runtime::frame-support: ✅ no migration for Indices    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Proxy    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Recovery    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Multisig    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Utility    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Tips    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Bounties    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Treasury    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for TransactionPayment    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Vesting    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Currencies    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Tokens    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Balances    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for TransactionPause    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Scheduler    
2021-08-26 19:38:59.755  INFO main runtime::frame-support: ✅ no migration for Timestamp    
2021-08-26 19:38:59.756  INFO main try_runtime_cli: TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = 0, total weight = 128000000000000 (0)

cargo run --features with-mandala-runtime --features try-runtime -- try-runtime --wasm-execution=compiled --block-at=0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56 on-runtime-upgrade snap -s snapshot.bin
    Finished dev [unoptimized + debuginfo] target(s) in 0.62s
     Running `target/debug/acala try-runtime --wasm-execution=compiled --block-at=0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56 on-runtime-upgrade snap -s snapshot.bin`
2021-08-26 19:40:10.217  INFO main remote-ext: scraping key-pairs from state snapshot "snapshot.bin"    
2021-08-26 19:40:10.350  INFO main remote-ext: extending externalities with 1 manually injected key-values    
2021-08-26 19:40:10.352  INFO main remote-ext: injecting a total of 103852 keys    
2021-08-26 19:40:48.355  INFO main runtime::frame-support: ⚠️ System declares internal migrations (which *might* execute). On-chain `<wasm:stripped>` vs current storage version `<wasm:stripped>`    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for Sudo    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for SessionManager    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for AuraExt    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for Aura    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for Session    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for CollatorSelection    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for Authorship    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for EvmManager    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for EvmAccounts    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for EVMBridge    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for EVM    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for OrmlXcm    
2021-08-26 19:40:48.356  INFO main runtime::frame-support: ✅ no migration for UnknownTokens    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for XTokens    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for DmpQueue    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for CumulusXcm    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for PolkadotXcm    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for XcmpQueue    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for ParachainInfo    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for ParachainSystem    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for CompoundCash    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for Starport    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for ChainSafeTransfer    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for ChainBridge    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for RenVmBridge    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for AirDrop    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for NFT    
2021-08-26 19:40:48.357  INFO main runtime::frame-support: ✅ no migration for Incentives    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for HomaLite    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for HomaValidatorListModule    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for PolkadotBridge    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for StakingPool    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for NomineesElection    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for Homa    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for EmergencyShutdown    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for CdpEngine    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for CdpTreasury    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for Honzon    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for Loans    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for AuctionManager    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for Dex    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for Prices    
2021-08-26 19:40:48.358  INFO main runtime::frame-support: ✅ no migration for OrmlNFT    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for Rewards    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for Auction    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for OperatorMembershipBand    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for BandOracle    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for OperatorMembershipAcala    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for AcalaOracle    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for Democracy    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for PhragmenElection    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for Authority    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for TechnicalCommitteeMembership    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for TechnicalCommittee    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for HomaCouncilMembership    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for HomaCouncil    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for FinancialCouncilMembership    
2021-08-26 19:40:48.359  INFO main runtime::frame-support: ✅ no migration for FinancialCouncil    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for GeneralCouncilMembership    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for GeneralCouncil    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for GraduallyUpdate    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Indices    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Proxy    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Recovery    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Multisig    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Utility    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Tips    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Bounties    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Treasury    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for TransactionPayment    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Vesting    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Currencies    
2021-08-26 19:40:48.360  INFO main runtime::frame-support: ✅ no migration for Tokens    
2021-08-26 19:40:48.361  INFO main runtime::frame-support: ✅ no migration for Balances    
2021-08-26 19:40:48.361  INFO main runtime::frame-support: ✅ no migration for TransactionPause    
2021-08-26 19:40:48.361  INFO main runtime::frame-support: ✅ no migration for Scheduler    
2021-08-26 19:40:48.361  INFO main runtime::frame-support: ✅ no migration for Timestamp    
2021-08-26 19:40:48.361  INFO main try_runtime_cli: TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = 0, total weight = 128000000000000 (0)

cargo run --features with-mandala-runtime --features try-runtime -- try-runtime --wasm-execution=compiled --block-at=0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56 --url="wss://karura.api.onfinality.io/public-ws" offchain-worker live -s snapshot.bin
    Finished dev [unoptimized + debuginfo] target(s) in 0.57s
     Running `target/debug/acala try-runtime --wasm-execution=compiled --block-at=0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56 '--url=wss://karura.api.onfinality.io/public-ws' offchain-worker live -s snapshot.bin`
2021-08-26 19:41:36.776  INFO main remote-ext: initializing remote client to "wss://karura.api.onfinality.io/public-ws"    
2021-08-26 19:41:37.673  INFO main remote-ext: scraping key-pairs from remote @ 0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56    
2021-08-26 19:41:37.673  INFO main remote-ext: downloading data for all modules.    
2021-08-26 19:44:02.482  INFO main remote-ext: Querying a total of 103850 keys    
2021-08-26 19:46:24.114  INFO main remote-ext: writing to state snapshot file "snapshot.bin"    
2021-08-26 19:46:24.175  INFO main remote-ext: extending externalities with 0 manually injected key-values    
2021-08-26 19:46:24.176  INFO main remote-ext: injecting a total of 103852 keys    
2021-08-26 19:47:04.371  INFO main try_runtime_cli: OffchainWorkerApi_offchain_worker executed without errors. 

cargo run --features with-mandala-runtime --features try-runtime -- try-runtime --wasm-execution=compiled --block-at=0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56 --url="wss://karura.api.onfinality.io/public-ws" offchain-worker snap -s snapshot.bin
    Finished dev [unoptimized + debuginfo] target(s) in 0.56s
     Running `target/debug/acala try-runtime --wasm-execution=compiled --block-at=0xd1c562b16b954f6536d677ccfa9a1cfd96f1f72c5b3f904db653e704bdb8fe56 '--url=wss://karura.api.onfinality.io/public-ws' offchain-worker snap -s snapshot.bin`
2021-08-26 19:48:00.568  INFO main remote-ext: scraping key-pairs from state snapshot "snapshot.bin"    
2021-08-26 19:48:00.699  INFO main remote-ext: extending externalities with 0 manually injected key-values    
2021-08-26 19:48:00.700  INFO main remote-ext: injecting a total of 103852 keys    
2021-08-26 19:48:38.927  INFO main try_runtime_cli: OffchainWorkerApi_offchain_worker executed without errors.

@shaunxw shaunxw merged commit 07998bf into master Aug 26, 2021
@shaunxw shaunxw deleted the sw/migrations branch August 26, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate PalletVersions
2 participants
@shaunxw @xlc