Scala Crossbuild of Client Library with Scala 2.13 (#93) #94
Conversation
JaCoCo code coverage report - scala:2.12.17
|
There was a problem hiding this comment.
Looks good, I suggest a couple of improvements:
- please update the
buildworkflow so that the 2.13 library is also built and tested (maybe another step for clientLibrary crossbuilt withstb ++ ...targets - similarly, I think that the release workflow does not release 2.13 variant which is important. Again, either solve by
++crossbuild directly or (if this failed for some reason, another step with 2.13 explicitly. Later on, we could test-release both 2.12 and 2.13 together
build.sbt
Outdated
| @@ -52,6 +60,7 @@ lazy val clientLibrary = project // no need to define file, because path is same | |||
| name := "login-service-client-library", | |||
| libraryDependencies ++= clientLibDependencies, | |||
| javacOptions ++= commonJavacOptions, | |||
| crossScalaVersions := Seq(scala212, "2.13.12") | |||
There was a problem hiding this comment.
Here, I suggest defining
lazy val scala213 = "2.13.12"
and then
| crossScalaVersions := Seq(scala212, "2.13.12") | |
| crossScalaVersions := Seq(scala212, scala213) |
There was a problem hiding this comment.
Hi, so I tested a local release and it does indeed publish the 2.13 version. I just haven't made a release tag yet since I'm waiting for this to be reviewed and merged before I do. ci-release uses +publish which publishes all the crossbuild versions. So no worries there.
Will have a look at testing.
There was a problem hiding this comment.
Hi, so I tested a local release and it does indeed publish the 2.13 version. I just haven't made a release tag yet since I'm waiting for this to be reviewed and merged before I do. ci-release uses +publish which publishes all the crossbuild versions. So no worries there.
Oh, that's great, I missed that.
|
@dk1844 Ran tests with the workflow change and it tests both scala versions for the Client Library. So above comments should be sorted. Here are the logs showing the above: Setting the Project to Scala 2.13: Passed tests for Client Lib in 2.13: Link to Log: https://github.com/AbsaOSS/login-service/actions/runs/7652532167/job/20852485618 |
Created a Package of the Client Library for Scala 2.13.
Please let me know if any other scala versions require compatibility?
Also included some general cleanup of imports and a change to the Build.sbt to avoid publishing of the root project to Sonatype.