Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release process support #3

Closed
dk1844 opened this issue Jan 30, 2023 · 2 comments · Fixed by #91
Closed

Add release process support #3

dk1844 opened this issue Jan 30, 2023 · 2 comments · Fixed by #91
Assignees
@TheLydonKing

Comments

@dk1844
Copy link
Collaborator

dk1844 commented Jan 30, 2023

Release process support is missing, let's consider using the same setup as other AbsaOSS tools.

Perhaps get inspired by https://github.com/AbsaOSS/spark-partition-sizing
@Zejnilovic
Copy link
Collaborator

Zejnilovic commented Jan 31, 2023 •
edited
Loading

This is not a library, so I would opt against pushing to maven central. I would just drop the files to GitHub release.

Edit: Adding a picture, as the explanation might not be the best.

image

@dk1844
Copy link
Collaborator Author

dk1844 commented Feb 2, 2023

Generally, yes, but there may be covenience parts of the project where releasing might make sense - #11

@TheLydonKing TheLydonKing linked a pull request Jan 18, 2024 that will close this issue
#3 add release process support #91
Merged
TheLydonKing added a commit that referenced this issue Jan 22, 2024
@TheLydonKing @dk1844
#3 add release process support (#91)
6eb5576 
* Initial Changes additions

* Remove unnecessary publishing values and change

* Update .github/workflows/publish_lib.yml

Co-authored-by: Daniel K <[email protected]>

* Change SBT Command

* Add Sonatype Override to test

* remove Sonatype Override to test

* Add back versionScheme

* Change Organization

* Add Maven Central Badge to README.md

---------

Co-authored-by: Daniel K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheLydonKing TheLydonKing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3 add release process support AbsaOSS/login-service
3 participants
@dk1844 @Zejnilovic @TheLydonKing