Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Timestamp/Date pattern contains both literal or variable length entry and fractions of second placeholders it's likely to cause error #677

Open
benedeki opened this issue Jul 17, 2019 · 2 comments
Assignees
Labels
bug Something isn't working priority: medium Important but not urgent Standardization Standardization Job affected

Comments

@benedeki
Copy link
Collaborator

benedeki commented Jul 17, 2019

Describe the bug

If Timestamp/Date pattern contains both literal parts or variable length entry (month name, day name, ...) and fractions of second placeholders namely if any literal part is before any second fraction placeholder it will fail Standardization of such filed or even crash with exception.

To Reproduce

Steps to reproduce the behavior OR commands run:

  1. Set the timestamp pattern to "'at' HH:mm:ss.SSS"
  2. Try to Standardize or just use 'EnceladusDateTimeParser.format'
  3. Exception, wouldn't it be SSS be at the tail it would "just" fail the conversion in Standardization

Expected behaviour

This needs to work properly

Additional context

The reason is that the quote characters are counted in when position of second fractions are analyzed. But in the actual string to convert they are not present making the index out of place, even outside the boundaries.

Related to #466

@benedeki benedeki added bug Something isn't working Standardization Standardization Job affected priority: high Critical to the health of the project labels Jul 17, 2019
@benedeki benedeki changed the title If Timestamp/Date pattern contains both literal parts and fractions of second placeholders it's likely to cause error If Timestamp/Date pattern contains both literal or variable length entry and fractions of second placeholders it's likely to cause error Jul 17, 2019
@benedeki benedeki self-assigned this Jul 22, 2019
@GeorgiChochov
Copy link
Collaborator

Check comments for TODO #677 (affects 3 files currently)

@dk1844
Copy link
Contributor

dk1844 commented Dec 8, 2021

May be solved by AbsaOSS/spark-data-standardization#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Important but not urgent Standardization Standardization Job affected
Projects
None yet
Development

No branches or pull requests

3 participants