Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Unmixed International Names #6

Open
Linxuski opened this issue Aug 27, 2021 · 4 comments
Open

Feature Request: Unmixed International Names #6

Linxuski opened this issue Aug 27, 2021 · 4 comments

Comments

@Linxuski
Copy link

Personally, I love the idea of allowing the game to use names from other languages. My issue with it, however, is how it mixes the names up (i.e. it'll generate a pawn with a Chinese first name and a Dutch surname).

Would it be possible to make it so that when the game generates a pawn with a first name from, say German, it'll only choose a surname from the same language?

Could also have a toggle for it in the mod's settings just in case others want mixed names.

@Linxuski Linxuski changed the title Unmixed International Names Feature Request: Unmixed International Names Aug 27, 2021
@AaronCRobinson
Copy link
Owner

Good feature request. I am a little rusty but I think I worked in a fair solution. There is a caveat, if a character has related pawns, the names can still get mixed (e.g. like an interracial relationship) but it seems to have fixed the names in majority of the cases.

I did not add a setting to toggle this but if it's requested, I will consider implementing it.

As a side note, many languages seem to lack nicknames. It would be great if contributors would include more but for now, there is a small fix that follows a default behavior.

Try it out and let me know if you experience any issues. I will temporarily leave this issue open for any more feedback you may have. Cheers.

https://github.com/AaronCRobinson/NamesGalore/releases/tag/v1.3.4

@Linxuski
Copy link
Author

Linxuski commented Sep 2, 2021

I was planning to post some name data I've worked on! So far I've done Dutch and French names (with the help of Behind the Name) and also Chinese names (romanised). I stopped after French, thinking "maybe I should see if I can actually get the feature before I start making stuff to compliment it".

@AaronCRobinson
Copy link
Owner

That's great to hear. Feel free to do a pull request or simply drop the files here as attachments and I will incorporate them. Watch for text encoding. I know at least one of the names incorporated now will not properly encode for me but unsure if the issue is the OS or the games encoding.

@Holgast
Copy link

Holgast commented Nov 22, 2021

I'd love this feature as well. Maybe a customisable percentage chance of whether to combine this way or with the regular international names setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants