From 0b9dced611c68fcb01884d19d0bf55c4c6f9ac65 Mon Sep 17 00:00:00 2001 From: positivelyjon Date: Tue, 12 Nov 2024 10:35:09 +0800 Subject: [PATCH 1/3] feat: add enhancement for dg --- docs/DeveloperGuide.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index b6ab7ecc1b9..a733c9c13e4 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -1129,6 +1129,11 @@ Team size: 5 * **Sample Input:** User enters `... d/2024-05-12 25:61` * **Expected Output:** The result display box shows `Invalid time format. Please enter a valid time between 00:00 and 23:59.` +6. **Update patient name in appointment when patient's name is edited** +* **Flaw:** When users edit a `person` with an appointment, the appointment's patient name still refers to the old name. +* **Enhancement:** During the EditPersonCommand, also edit any appointments with this patient to point to the new Person object. +* **Sample Input:** Suppose there is a person indexed 1 named John. Enter `edit person 1 n/Jonathan`. +* **Expected Output:** Any appointments with John should now refer to Jonathan.
From f84cff1378d24aee16e0507dc20011dcf3699c7c Mon Sep 17 00:00:00 2001 From: positivelyjon Date: Tue, 12 Nov 2024 10:44:25 +0800 Subject: [PATCH 2/3] feat: add sickness enhancmenet --- docs/DeveloperGuide.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index a733c9c13e4..5e9c3a0de60 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -1130,11 +1130,17 @@ Team size: 5 * **Expected Output:** The result display box shows `Invalid time format. Please enter a valid time between 00:00 and 23:59.` 6. **Update patient name in appointment when patient's name is edited** -* **Flaw:** When users edit a `person` with an appointment, the appointment's patient name still refers to the old name. +* **Flaw:** When users edit a `person` with a new name, his/her appointments still refer to the old name. * **Enhancement:** During the EditPersonCommand, also edit any appointments with this patient to point to the new Person object. -* **Sample Input:** Suppose there is a person indexed 1 named John. Enter `edit person 1 n/Jonathan`. +* **Sample Input:** Suppose there is a person indexed 1 named John. Execute `edit person 1 n/Jonathan`. * **Expected Output:** Any appointments with John should now refer to Jonathan. +7. **You can only add appointments without sickness or medicine, but not edit them** +* **Flaw:** When users edit an `appointment` such that sickness or medicine is null, the GUI invalidates this input even though these fields are optional. +* **Enhancement:** Change input validation for sickness and medicine to allow for null values. +* **Sample Input:** `edit appt 1 s/ m/` +* **Expected Output:** Appointment indexed 1 should have sickness and medicine shown as null +
-------------------------------------------------------------------------------------------------------------------- From 1693e5c01b0a327d19708fb9f75c15bb38919395 Mon Sep 17 00:00:00 2001 From: positivelyjon Date: Tue, 12 Nov 2024 10:45:12 +0800 Subject: [PATCH 3/3] fix: add fullstop --- docs/DeveloperGuide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index 5e9c3a0de60..54773e228c8 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -1139,7 +1139,7 @@ Team size: 5 * **Flaw:** When users edit an `appointment` such that sickness or medicine is null, the GUI invalidates this input even though these fields are optional. * **Enhancement:** Change input validation for sickness and medicine to allow for null values. * **Sample Input:** `edit appt 1 s/ m/` -* **Expected Output:** Appointment indexed 1 should have sickness and medicine shown as null +* **Expected Output:** Appointment indexed 1 should have sickness and medicine shown as null.