Avoid race condition in Reporter errorsBuilder #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaciv
requested changes
May 23, 2024
Comment on lines
+73
to
75
| def clearErrors(): Unit = { | ||
| errorsBuilder.clear() | ||
| } |
There was a problem hiding this comment.
Suggestion: add resetAndClearErrors method to avoid repeating subsequent reset and clearError calls in other places
| header = "", | ||
| ) | ||
|
|
||
| test("Multiple evaluations of invalid expressions should always fail") { |
There was a problem hiding this comment.
Add test case with mixed correct and incorrect expressions
Also check corner case, when invalid expression is the last one before reaching settings.resetAfterCount and next expression is valid
|
Closing since it touches core scex functionalities and the regression risk is too high |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17