Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPM Clock outputs Buggy based on what's expected per time signature #28

Open
patman023 opened this issue Jun 3, 2018 · 3 comments
Open
Labels

Comments

@patman023
Copy link

patman023 commented Jun 3, 2018

AS 0.6.8

X/4 Time

Unsure about 8th and 16th notes, but in relation to Quarter notes, Bar trigger outs are bugged on certain Time Signatures. Occurs at all BPM on regular duration (40-240)

  • 3/4 acts like 1/4
  • 6/4 acts like 2/4
  • 9/4 acts like (working) 3/4
  • 12/4 acts like 4/4
  • 15/4 acts like 5/4

X/8 Time

Assuming that a beat in 3/8 or 6/8 is a Dotted Quarter Note (as per how it would be Handled musically), 5/8 (for but one example) isn't outputting the beat correctly. Most X/8 Time Sigs are outputting One Beat for every Two 8ths (except for Numerators that are mults of 3, which work correctly).

It should be:

Bar: X----|X----|
Beat: X--X-|X--X-|
8th:  xxxxx|xxxxx|

What I'm seeing:

Bar:  X----|X----|
Beat: X-X-X|-X-X-| 
8th:  xxxxx|xxxxx|

I assume that things are implemented using only a small number of step counters, as opposed to a sequencer table lookup, so I don't know if this would be an easy thing to fix... :-S

My apologies if all of this is coming out wonky, I'd just like my stuff to actually sound vaguely prog, Like a mellower Meshuggah. https://youtu.be/bhPaY1HEjEc?t=1m42s

@AScustomWorks
Copy link
Owner

Just tested this and indeed it happens as you noticed, added to the queue.

@patman023
Copy link
Author

confirmed still an issue in 1.0.1. can produce video if needed.

@AScustomWorks
Copy link
Owner

Hi Pat, indeed, I took a look at the code but didn't saw an easy fix, I'll take another look and possibly refactor the code, can't give an estimated date though.
If anyone feels like diving in, you are welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants