Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#328 [fix] slack util deprecated api 수정 #329

Merged
merged 3 commits into from
Aug 27, 2024
Merged

#328 [fix] slack util deprecated api 수정 #329

merged 3 commits into from
Aug 27, 2024

Conversation

sohyundoh
Copy link
Member

✒️ 관련 이슈번호

Key Changes 🔑

  1. slack이 제공하는 의존성에서 보내는 사람을 지정하는 API가 deprecated 되고, slack 앱에서 지정하도록 변경됨에 따라 앱에서 지정 후 코드에서 제거하였습니다. 기존에 있던 주석들도 함께 지우고, String Builder 사용 방식도 수정하였습니다!

To Reviewers 📢

@sohyundoh sohyundoh requested a review from KWY0218 August 27, 2024 05:03
@sohyundoh sohyundoh self-assigned this Aug 27, 2024
KWY0218
KWY0218 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@KWY0218 KWY0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다! LGTM ~ ! 👍

@KWY0218
Copy link
Member

KWY0218 commented Aug 27, 2024

image

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ이미지 진짜 심각해 보여서 좋네요 👍

@sohyundoh sohyundoh merged commit e074ae8 into develop Aug 27, 2024
4 checks passed
@sohyundoh sohyundoh deleted the fix/#328 branch August 27, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KWY0218 KWY0218 KWY0218 approved these changes

Assignees

@sohyundoh sohyundoh

Labels
Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] Slack Util Deprecated API 수정
2 participants
@sohyundoh @KWY0218