Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch to use system octomap #483

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Conversation

wep21
Copy link
Collaborator

@wep21 wep21 commented Nov 8, 2024

@wep21 wep21 changed the base branch from master to rolling November 8, 2024 06:03
@wep21 wep21 changed the title Switch system octomap build: switch to use system octomap Nov 8, 2024
@wep21 wep21 closed this Nov 8, 2024
@wep21 wep21 reopened this Nov 8, 2024
@wep21 wep21 requested a review from Ryanf55 November 8, 2024 06:10
@wep21
Copy link
Collaborator Author

wep21 commented Nov 8, 2024

 /opt/ros/rolling/include/octomap_msgs/conversions.h 
/opt/ros/rolling/include/sensor_msgs/sensor_msgs/image_encodings.hpp

octomap_msgs conversions.h seems to be placed in the wrong directory.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Nov 8, 2024

 /opt/ros/rolling/include/octomap_msgs/conversions.h 
/opt/ros/rolling/include/sensor_msgs/sensor_msgs/image_encodings.hpp

octomap_msgs conversions.h seems to be placed in the wrong directory.

Fixed by this PR: OctoMap/octomap_msgs#20

I requested them to do a release. In the mean time, I think this is an ok patch to get our CI running again.

@Ryanf55 Ryanf55 added ros2 Affects ROS 2 bug labels Nov 8, 2024
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Nov 8, 2024

The octomap maintainers have issues PR's to ROSDIstro for a patch release. I expect those to go in a few days, and this to be available shortly. Perhaps we wait a bit before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ros2 Affects ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rolling: octomap rosdep not found
2 participants