Added support for postgresql_privs #134
Conversation
| @@ -38,6 +38,9 @@ postgresql_users: [] | |||
| # List of user privileges to be applied (optional) | |||
| postgresql_user_privileges: [] | |||
|
|
|||
| # List of privileges to be applied (optional) | |||
| postgresql_privileges: [] | |||
There was a problem hiding this comment.
as to avoid being misleading perhaps this should be postgresql_db_priveleges?
- Merged together privileges.yml and users_privileges.yml - Removed related include and tag from main.yml - Added data for test - Changed description
|
@ArmiT possible to get conflicts resolved with latest master? |
|
Is this the same as #181? Which one should be merged? |
|
probably this one but, is old and still needs work. |
| @@ -38,6 +38,9 @@ postgresql_users: [] | |||
| # List of user privileges to be applied (optional) | |||
| postgresql_user_privileges: [] | |||
|
|
|||
| # List of database privileges to be applied (optional) | |||
| postgresql_db_priveleges: [] | |||
There was a problem hiding this comment.
Typo
| postgresql_db_priveleges: [] | |
| postgresql_db_privileges: [] |
| type: "{{ item.type | default(\"table\") }}" | ||
| sudo: yes | ||
| sudo_user: "{{postgresql_admin_user}}" | ||
| with_items: postgresql_db_priveleges |
There was a problem hiding this comment.
Typo
| with_items: postgresql_db_priveleges | |
| with_items: postgresql_db_privileges |
| @@ -17,3 +17,11 @@ postgresql_users: | |||
| postgresql_user_privileges: | |||
| - name: baz | |||
| db: foobar | |||
|
|
|||
| postgresql_db_priveleges: | |||
There was a problem hiding this comment.
Typo
| postgresql_db_priveleges: | |
| postgresql_db_privileges: |
|
I think all the naming here should really be simplified down to https://docs.ansible.com/ansible/latest/modules/postgresql_privs_module.html |
|
@nchudleigh , in short, yes. I've got some time to help with this project, and have already cleaned up a lot of old PR's. There are also some new helpers that can review/comment. |
|
@nchudleigh did you end up opening another PR? I'm looking forward to having this. Can also try to contribute if needed. |
|
@RCM7 No, I got frustrated with the pace of the maintainers and stopped contributing to this project. I went with an approach of using the core ansible postgres modules and found that was good enough for my use-case. |
|
@nchudleigh yeah I ended up doing the same ! |
|
Related to Issue #175 |
|
Any progress on this? |
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! |
|
This pr has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details. |
No description provided.