Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in primordial chemistry chemical heating #1641

Open
psharda opened this issue Aug 21, 2024 · 0 comments
Open

Fix bug in primordial chemistry chemical heating #1641

psharda opened this issue Aug 21, 2024 · 0 comments
Assignees
@psharda
Labels
bug

Comments

@psharda
Copy link
Collaborator

psharda commented Aug 21, 2024

This bug fix needs to be propagated across the primordial chemistry pipeline: https://github.com/psharda/GPUAstroChem/commit/ea95fb62d3b79fa18db5e5dc796c5974d8767bea

It does not matter for primordial chemistry, but creates a 10% error at low, non-zero metallicities. Just noting it down for now in case I forget to fix it later on.
@psharda psharda added the bug label Aug 21, 2024
@psharda psharda self-assigned this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psharda psharda

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psharda