Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower the default ode_max_steps #1634

Open
zingale opened this issue Jul 29, 2024 · 0 comments
Open

lower the default ode_max_steps #1634

zingale opened this issue Jul 29, 2024 · 0 comments

Comments

@zingale
Copy link
Member

zingale commented Jul 29, 2024

Right now, integrator.ode_max_steps = 150000 by default. This is very high, and if we need this many steps, we most likely have a problem (like a bad Jacobian). In many problems, lowering this to 10000 or so and then turning on integrator.use_burn_retry speeds up the execution a lot.

We should lower this default to something smaller like 25000. This will force retries (either at the burner or application code level) and should perform better on GPUs where the divergence in the number of steps different zones needs can be a big slowdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant