Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

有考虑加CONTRIBUTING文档嘛? #11

Open
LiarCoder opened this issue Jul 24, 2024 · 5 comments
Open

有考虑加CONTRIBUTING文档嘛? #11

LiarCoder opened this issue Jul 24, 2024 · 5 comments

Comments

@LiarCoder
Copy link
Collaborator

No description provided.

@AKclown
Copy link
Owner

AKclown commented Jul 24, 2024

可以,如果你有兴趣的话,可以提PR,维护

@AKclown
Copy link
Owner

AKclown commented Jul 24, 2024

项目大体结构在这里可以看到

@AKclown
Copy link
Owner

AKclown commented Jul 31, 2024

@LiarCoder hello,LiarCoder。 你有兴趣做这个需求吗? 这个优先级蛮高的,先保证基础功能的可用性,在追加stash的功能

添加测试用例以及合并main触发CI

@LiarCoder
Copy link
Collaborator Author

@LiarCoder hello,LiarCoder。 你有兴趣做这个需求吗? 这个优先级蛮高的,先保证基础功能的可用性,在追加stash的功能

添加测试用例以及合并main触发CI

sorry,这几天都在键盘冒烟,没看到消息。

  • 我平时写测试用例比较少,相关的框架也不甚了解。😂,我目前工作中用到测试框架是 jest
  • 触发CI这方面我也没有什么接触。倒是看过几篇GitHub Actions的文章,我觉得你想要的效果就是在有PR合并到 main 分支时,利用GitHub Actions来自动运行测试用例脚本(这样的话,应该就先得把测试用例给搞好吧)?大概是下面这个意思吗?(这是我向chatGPT询问得到的答案)
name: CI Workflow

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - name: Checkout repository
        uses: actions/checkout@v2

      - name: Set up Node.js
        uses: actions/setup-node@v2
        with:
          node-version: '14'

      - name: Install dependencies
        run: npm install

      - name: Run tests
        run: npm test

      - name: Generate test report
        if: always()
        run: npm run test:report

虽然这两者对我来说都不怎么熟悉,不过我还挺有兴趣学习一下的,我这几天可以先研究研究。

@AKclown
Copy link
Owner

AKclown commented Aug 2, 2024

是的,我的想法是合并main分支发包的时候,必须测试用例要通过。因为功能不多覆盖率我想做到90%及以上。我想用 git action + jest + ink-testing-library来做。嗯嗯,这个项目有空写写就好工作重要。 如果你没时间的话,你可以把重心放到stash功能上,这个我有空会集成上去

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants