Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing the TimeIndex class - the constructor method #8

Closed
Peter9192 opened this issue May 18, 2022 · 2 comments · Fixed by #12
Closed

Implementing the TimeIndex class - the constructor method #8

Peter9192 opened this issue May 18, 2022 · 2 comments · Fixed by #12

Comments

@Peter9192
Copy link
Contributor

Peter9192 commented May 18, 2022

In #7 we drafted a preliminary interface for the main time-index object. Now, we want to start implementing it, starting with the constructor (the __init__ method).

Also see the discussion in AI4S2S/proto#3

@Peter9192
Copy link
Contributor Author

The reference implementation creates two dataframes, but they are based on the target variable input array:
https://github.com/AI4S2S/proto/blob/0dd397f6101573544f10a55a4205e037e69acdfe/RGCPD/class_RGCPD.py#L302

Instead, I'd prefer to just create a new array independently from any input data.

@geek-yang
Copy link
Member

Instead, I'd prefer to just create a new array independently from any input data.

I think this is a good choice. We manipulate time index and train/test labels in this class and save the output as an independent data (e.g. dataframe). We can bring it to the preprocessing module when the actual operations take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants