Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repr to the preprocessor object #162

Open
geek-yang opened this issue Feb 23, 2023 · 1 comment
Open

Add repr to the preprocessor object #162

geek-yang opened this issue Feb 23, 2023 · 1 comment

Comments

@geek-yang
Copy link
Member

Following the suggestions from @BSchilperoort in PR #152, we need a nice repr representation of preprocessor object, which informs the user the setup of preprocessor.

@BSchilperoort
Copy link
Contributor

It would also be nice (and more complete) to expose the stored parameters as @propertys. E.g.:

@property
def detrend(self):
    return self._detrend

etc. for the other parameters. This makes it easier to inspect this item later, for users who are for example working in a notebook.

We could also open an issue for this, and then also add a nicer repr which tells you the settings (and if the preprocessor is fit already, with an is_fit property).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants