Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomizable gripper & extended grippers domain, rewritten in python #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guicho271828
Copy link
Contributor

this is an unrelated pull request that makes gripper randomizable. The original behavior is the same when additional arguments are not supplied.

@guicho271828 guicho271828 changed the title randomizable gripper randomizable gripper & extended grippers domain, rewritten in python Nov 26, 2021
@guicho271828 guicho271828 mentioned this pull request Nov 26, 2021
Copy link
Collaborator

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a "make test" test case for both domains?


parser.add_argument("balls", type=int, help="the number of balls")
parser.add_argument("--seed", "-s", type=int, help="random seed")
parser.add_argument("--randomize", "-r", action="store_true", help="randomize the initial state and the goal if present")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to combine these two options into the --seed option and randomize if --seed is given.


# Grippers (python)

usage: gripper.py [-h] [--seed SEED] balls robots grippers rooms
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename the file to grippers.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants