Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ''other'' measurements #197

Open
celineaubert opened this issue Mar 20, 2019 · 4 comments
Open

Add ''other'' measurements #197

celineaubert opened this issue Mar 20, 2019 · 4 comments
Assignees
Labels
flexibility add more flexibility for user high priority measurement Issue linked to the measurment module

Comments

@celineaubert
Copy link
Collaborator

Maybe reused the form developed for RTB or add a ‘’my trait is missing’’ button

@celineaubert celineaubert added enhancement New feature or request measurement Issue linked to the measurment module labels Mar 20, 2019
@celineaubert
Copy link
Collaborator Author

celineaubert commented May 15, 2019

@omarbenites For the first release, we can develop something simple for us and the users.
When they click on ''create a new measurement'', a new line appears in the table with text boxes. It's easy for them to create the measurement they want.
Pro: No frustration on their side, easy and quick to develop
Cons: Less harmonization, no link with the ontology, no link with GitHub

Later, we can develop a way to add a GitHub issue for each '' new measurement'' created.

image

Edit: This solution needs to be adapted to be KDSmart compliant: TraitName, TraitDataType, TraitValiadation and are required

@celineaubert
Copy link
Collaborator Author

@omarbenites To be KDSmart compliant we could try to have the following info for a new measurement:

TraitValidation: -100.00 <= x <= 10000.00
TraitDataType: DECIMAL
TraitName: Crop_Parametermeasured(subgroup)_Measurement_unit
TraitAlias: Crop_measurement

@omarbenites
Copy link
Contributor

Might we move this issue for the second release? Just in case we run out time...

@omarbenites omarbenites changed the title Develop a protocol for users to add missing measurements Add missing measurements Nov 15, 2019
@celineaubert celineaubert changed the title Add missing measurements Add ''other'' measurements Dec 18, 2019
@celineaubert celineaubert added flexibility add more flexibility for user high priority and removed enhancement New feature or request labels Dec 18, 2019
@celineaubert
Copy link
Collaborator Author

celineaubert commented Nov 24, 2020

Hi @omarbenites ,
below is an update for this issue, compatible with Angular.

  • In Crop measurements drop down menu ''Other'' could be the first choice.

  • Once users select ''Other'', the following line is added to the crop measurements list:
    image

  • Only the name of the measurement should be editable. The parameter measured and the unit will come from from Crop-measurement file, line 755 : https://docs.google.com/spreadsheets/d/1Hl3-u11cHkrVDM6pdADkUCMzuauz7fud7RH7PIWKSX8/edit#gid=1134960487

  • To be compliant with KDSmart, a TraitName and a TraitAlias need to be created and be different for each ''other'' measurement.
    My suggestion would be to concatenate the following information:
    TraitName: Crop_Parametermeasured(subgroup)_Measurement_unit
    TraitAlias: Crop_measurement

Let me know if you have suggestions. A similar feature needs to be build for Phenology, Soil and Weather

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flexibility add more flexibility for user high priority measurement Issue linked to the measurment module
Projects
None yet
Development

No branches or pull requests

4 participants