Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output electron distribution function in image header #79

Open
gnwong opened this issue Mar 21, 2022 · 3 comments
Open

output electron distribution function in image header #79

gnwong opened this issue Mar 21, 2022 · 3 comments

Comments

@gnwong
Copy link
Collaborator

gnwong commented Mar 21, 2022

the eDF (and associated variables) should be saved in image output files. as far as I can tell, they're not currently included. should be an easy fix, once we decide where to put the output functionality.

thanks to Koushik for noticing this problem

@bprather
Copy link
Collaborator

@gnwong
Copy link
Collaborator Author

gnwong commented Mar 22, 2022

I don't think so. That's set https://github.com/AFD-Illinois/ipole/blob/master/model/iharm/model.c#L892. I'm talking about this parameter https://github.com/AFD-Illinois/ipole/blob/master/src/par.c#L137 along with associated things like

/*power law parameters*/
. Am I missing something?

@bprather
Copy link
Collaborator

Oh, the emission type. That's a bit more than just the eDF, since you can use it for a bunch of things related to emissivities and not every value is documented. I'd initially avoided recording it (and the similarly untested powerlaw params) for that reason.

I don't really have time to put in and test the new values, but they should be simple enough to add to that folder in some consistent way when writing the file header, happy to accept that PR quickly.

@bprather bprather removed their assignment May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants