Skip to content

Commit

Permalink
code refinement
Browse files Browse the repository at this point in the history
  • Loading branch information
Arielpetit committed Nov 12, 2024
1 parent 85ffa40 commit 613ab78
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/develop.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
<server>
<id>github-ledgers</id>
<username>${{ github.actor }}</username>
<password>${{ secrets.WEBANK_ONLINE_TOKEN }}</password>
<password>${{ secrets.WEBANK_ACCESS_TOKEN }}</password>
</server>
</servers>
</settings>" > ~/.m2/settings.xml
Expand Down
26 changes: 20 additions & 6 deletions obs/obs-service-impl/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,32 @@
</dependency>


<!-- <dependency>-->
<!-- <groupId>de.adorsys.ledgers</groupId>-->
<!-- <artifactId>ledgers-bank-account-service-api</artifactId>-->
<!-- </dependency>-->

<dependency>
<groupId>de.adorsys.ledgers</groupId>
<artifactId>ledgers-bank-account-service-api</artifactId>
<groupId>de.adorsys.webank</groupId>
<artifactId>webank-bank-account-service-api</artifactId>
<version>0.1-SNAPSHOT</version>
</dependency>
<!-- test depedencies -->

<!-- <dependency>-->
<!-- <groupId>de.adorsys.ledgers</groupId>-->
<!-- <artifactId>ledgers-bank-account-service-impl</artifactId>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->

<dependency>
<groupId>de.adorsys.ledgers</groupId>
<artifactId>ledgers-bank-account-service-impl</artifactId>
<groupId>de.adorsys.webank</groupId>
<artifactId>webank-bank-account-service-impl</artifactId>
<version>0.1-SNAPSHOT</version>
<scope>test</scope>
</dependency>


<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
Expand All @@ -69,9 +83,9 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>de.adorsys.ledgers</groupId>
<groupId>de.adorsys.webank</groupId>
<artifactId>webank-server-utils</artifactId>
<version>${project.version}</version>
<version>0.1-SNAPSHOT</version>
<scope>test</scope>
</dependency>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

import com.adorsys.webank.obs.dto.RegistrationRequest;
import com.adorsys.webank.obs.service.RegistrationServiceApi;
import de.adorsys.ledgers.bank.api.domain.AccountTypeBO;
import de.adorsys.ledgers.bank.api.domain.AccountUsageBO;
import de.adorsys.ledgers.bank.api.domain.BankAccountBO;
import de.adorsys.ledgers.bank.api.service.BankAccountService;

import de.adorsys.webank.bank.api.domain.AccountTypeBO;
import de.adorsys.webank.bank.api.domain.AccountUsageBO;
import de.adorsys.webank.bank.api.domain.BankAccountBO;
import de.adorsys.webank.bank.api.service.BankAccountService;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package com.adorsys.webank.obs.serviceimpl;

import com.adorsys.webank.obs.dto.RegistrationRequest;
import com.adorsys.webank.obs.serviceimpl.OBSServiceImpl;
import de.adorsys.ledgers.bank.api.domain.BankAccountBO;
import de.adorsys.ledgers.bank.api.service.BankAccountService;


import de.adorsys.webank.bank.api.domain.BankAccountBO;
import de.adorsys.webank.bank.api.service.BankAccountService;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.InjectMocks;
Expand Down

0 comments on commit 613ab78

Please sign in to comment.