47 create a ledgers deposit account rest client #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NkwaTambe
requested review from
francis-pouatcha,
Elwizzy12,
Arielpetit,
Koufan-De-King,
nancymuyeh and
yvanhenang
Arielpetit
requested changes
Oct 30, 2024
Comment on lines
+32
to
+35
| <groupId>org.springframework.cloud</groupId> | ||
| <artifactId>spring-cloud-openfeign-core</artifactId> | ||
| <version>4.1.3</version> | ||
| <scope>compile</scope> |
There was a problem hiding this comment.
This version has to be in the parent pom not here
Comment on lines
+38
to
+41
| <groupId>de.adorsys.ledgers.deposit.api</groupId> | ||
| <artifactId>ledgers-deposit-account-rest-api</artifactId> | ||
| <version>6.1-SNAPSHOT</version> | ||
| <scope>compile</scope> |
There was a problem hiding this comment.
The version should not be declared like this for the module dependency, use this
<version>${project.version}</version>
Arielpetit
requested changes
Oct 30, 2024
we won't be writting a test for these because we won't be making use of any mappers.. test could be written if we made use of the mapper.. taking reference from |
|
Changed deployment strategy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created ledgers deposit-rest-client