This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Add support for external API Gateway in the dashboards #215 #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #215
This PR adds support for external API Gateway in the dashboards, currently, this plugin uses the stage and service name to build the API gateway name.
When you have an external API Gateway the dashboard widgets for API metrics shows always empty if the API Gateway name is different.
How did you implement it:
To solve this problem I added a new config property named
dashboardConfig
as a group and a property namedapiName
and if the value is present use the custom name.config example:
How can we verify it:
I published a version in my personal npm organization with these changes
https://www.npmjs.com/package/@slslv/serverless-plugin-aws-alerts