Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stress to virials internally #527

Open
ilyes319 opened this issue Jul 19, 2024 · 0 comments
Open

Change stress to virials internally #527

ilyes319 opened this issue Jul 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ilyes319
Copy link
Contributor

** Current problem **

The stress and virials are currently used separatly. It leads to duplicating code and confusion.

** Solution **

Change everything to virials and adapt the weights to it be the consistent (rescale by the volume of the cell if stress_weight is selected).

@ilyes319 ilyes319 added the enhancement New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant