Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #1

Open
5 tasks
ddongule opened this issue Apr 21, 2020 · 0 comments
Open
5 tasks

Review #1

ddongule opened this issue Apr 21, 2020 · 0 comments

Comments

@ddongule
Copy link
Member

πŸ˜‰μž˜ν•œ 점

  • ν”„λ‘œμ νŠΈμ™€ κ·Έ μ•ˆμ˜ 앱듀을 잘 λ§Œλ“€μ–΄ λƒˆμŠ΅λ‹ˆλ‹€.
  • ν”„λ‘œμ νŠΈμ™€ 앱듀을 url을 톡해 잘 μ—°κ²°ν–ˆμŠ΅λ‹ˆλ‹€.
  • λ‹€μ–‘ν•œ html νƒœκ·Έλ“€μ„ μ‚¬μš©ν•΄ μœ μ €κ°€ 보기 쉽도둝 ν”„λ‘œν•„ νŽ˜μ΄μ§€λ₯Ό λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹€.
  • ν”„λ‘œμ νŠΈ μ•ˆμ˜ base.html을 μ‚¬μš©ν•΄ ν…œν”Œλ¦Ώμ„ 잘 ν™•μž₯μ‹œμΌœ λ°˜λ³΅λ˜λŠ” μ½”λ“œλ₯Ό μ€„μ˜€μŠ΅λ‹ˆλ‹€.
  • 이미지λ₯Ό λ„£μœΌλ €κ³  μ‹œλ„ν–ˆκ³ , 링크와 글을 μ•Œλ§žκ²Œ λ°°μΉ˜ν•΄ μ•Œμ°¬ λ‚΄μš©μ˜ μžκΈ°μ†Œκ°œλ₯Ό μ¨μ£Όμ—ˆμŠ΅λ‹ˆλ‹€.

πŸ˜Žκ°œμ„  사항(같이 배울 λ‚΄μš©μ΄ ν¬ν•¨λ˜μ–΄ μžˆμ–΄μš”!)

  • 이미지 νŒŒμΌμ„ λΆˆλŸ¬μ˜€λŠ” 방법에 λŒ€ν•΄ 곧 배울 μ˜ˆμ •μ΄λ‹ˆ κΆκΈˆν•˜μ‹œλ‹€λ©΄ static νŒŒμΌμ— λŒ€ν•΄ 미리 검색해 μ˜€μ…”λ„ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€. λ§Œμ•½ κ·Έ 전에 이미지λ₯Ό λ„μš°κ³  μ‹Άλ‹€λ©΄ img src="" μ•ˆμ— 본인이 이미 λ‹€λ₯Έ νŽ˜μ΄μ§€μ— 올린 이미지 사진 μ£Όμ†Œλ₯Ό 넣어주셔도 쒋을 것 κ°™μ•„μš”. <img src="blog.jpg" /> λŒ€μ‹  <img src="https://scontent-ssn1-1.cdninstagram.com/v/t51.2885-19/s320x320/93079692_235248881160318_6708024375527866368_n.jpg?_nc_ht=scontent-ssn1-1.cdninstagram.com&_nc_ohc=yl7C9U2YAhEAX9JzTEq&oh=775eaa264f752fd7cd4ba88685f379a1&oe=5EC809E4" />λ₯Ό λ„£μœΌλ©΄ 주연씨 ν”„λ‘œν•„ 사진이 잘 λ“€μ–΄κ°„λ‹€λŠ” 것을 확인해 λ³Ό 수 μžˆμŠ΅λ‹ˆλ‹€. (사진은 주연씨 μΈμŠ€νƒ€ ν”„λ‘œν•„μ— μ—…λ‘œλ“œν•œ μ£Όμ†Œλ‘œ λ”°μ™”μŠ΅λ‹ˆλ‹€.)
  • styleκ³Ό css에 λŒ€ν•΄ ν•¨κ»˜ 쑰금 더 μ•Œμ•„κ°€λ³΄μ•„μš”!
  • commit을 쑰금 더 ν•΄λ³΄λ©΄μ„œ gitκ³Ό μΉœν•΄μ§€λŠ” μ‹œκ°„μ„ 가지셔도 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.
  • settings.py의 TEMPLATES μ•ˆμ˜ DIR에 BASE_DIR을 ν™œμš©ν•œ μƒλŒ€ 경둜λ₯Ό λ„£λŠ” 것을 μΆ”μ²œλ“œλ¦½λ‹ˆλ‹€. μ•„λ§ˆ λΉ λ₯΄κ²Œ ν•˜κ³  λ„˜μ–΄κ°€μ„œ ν—·κ°ˆλ¦΄ 수 μžˆμ–΄μš”. μ°Ύμ•„λ³΄μ‹œκ³ , λͺ¨λ₯΄λŠ” 뢀뢄이 생긴닀면 κΌ­ λ¬Όμ–΄λ³΄μ„Έμš”!
  • Sub μ•±(blog, daily)λ“€μ˜ urls.pyμ—μ„œ viewsλ₯Ό import ν•  λ•Œμ— (μ˜ˆμ‹œ) import blog.views 말고 from . import viewsλ₯Ό 쓰셔도 μ’‹μŠ΅λ‹ˆλ‹€. μ–΄μ°¨ν”Ό blog.views.μ–΄μ©Œκ³  μ•ˆμ—μ„œ blog.λŠ” 계속 반볡될 κ²ƒμ΄λ‹ˆκΉŒμš”!(daily μ•± λ‚΄μ˜ urls.py도 λ§ˆμ°¬κ°€μ§€ μž…λ‹ˆλ‹€.) -> 잘 λͺ¨λ₯΄κ² μœΌλ©΄ λ¬Όμ–΄λ³΄μ„Έμš”!

πŸ₯³λ§Œλ“œλŠλΌ μˆ˜κ³ ν•˜μ…¨μ–΄μš”!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant