Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React.js --> Next.js Refactor #58

Closed
Vercin-G opened this issue Oct 1, 2023 · 2 comments
Closed

React.js --> Next.js Refactor #58

Vercin-G opened this issue Oct 1, 2023 · 2 comments

Comments

@Vercin-G
Copy link
Collaborator

Vercin-G commented Oct 1, 2023

Once PR #57 becomes live, a fundamental rebuild of CavApps in Next.JS will be an eventual requirement.

This is due to the following reasons:

  • As the JavaScript count increases, react will download every javascript file for every page in CavApps, even if certain pages are never opened by the end user.
  • Severside rendering will allow us to eliminate the API call on the clientside. Thus removing the requirement to download an additional 10mb of data on the clientside.
  • The CSS styling for CavApps is starting to become cluttered and intuitive. While manual styling may suit us for some time, Next.js' native support of external CSS tools may serve useful if others start developing in CavApps.
  • CavApps was originally built as a single page ADR project. However, should we wish to expand to more serious development. i.e. utilizing authentication elements such as keycloak for multiple apps. It may be useful to update to a framework which allows us extra security.
@Vercin-G
Copy link
Collaborator Author

As of now, the code for the migration is complete enough to warrant a staging build and deployment. once i can iron out the staging build on a live setting, i can finish off work on the migration.

see here for the current nextJS version: https://github.com/Vercin-G/adr/tree/nextjs-dev

@SyniRon
Copy link
Collaborator

SyniRon commented Nov 28, 2024

closing as this was done in #70

@SyniRon SyniRon closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants