Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All public functions could take impl AsRef<[u8]> instead of &str #11

Open
ccptr opened this issue Feb 6, 2024 · 0 comments
Open

All public functions could take impl AsRef<[u8]> instead of &str #11

ccptr opened this issue Feb 6, 2024 · 0 comments

Comments

@ccptr
Copy link
Contributor

ccptr commented Feb 6, 2024

I'm using this crate as a library for a personal tool, and came across this issue when trying to use environment variables as input without validating them to be UTF-8. Now that I'm thinking about it I could just error out if they're not valid UTF-8, but I would still like to be able to do these kinds of things and it is a needless restriction of the API. I'm curious to know your thoughts and/or reasoning behind it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant