Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading junk in OCLC numbers #61

Open
daniel-barrows opened this issue Dec 9, 2024 · 1 comment
Open

Leading junk in OCLC numbers #61

daniel-barrows opened this issue Dec 9, 2024 · 1 comment

Comments

@daniel-barrows
Copy link

Sometimes Citer includes leading junk characters in the oclc parameter.

Examples:

In all cases, the correct OCLC number is the numbers without the leading letters.

I have observed examples but I did not record them.

Note: Citer sometimes includes OCLC numbers in output and sometimes doesn't. My guess is that is related to OCLC usage limits and is not a bug, but it may make verifying this problem difficult.

@5j9
Copy link
Owner

5j9 commented Dec 12, 2024

Interesting! This is actually coming from Citoid API:
https://en.wikipedia.org/api/rest_v1/data/citation/mediawiki/978-80-210-8779-8
(It took me several retries to get an output with OCLC which explains the erratic results)

[
    {
        "key": "ATXZU78G",
        "version": 0,
        "itemType": "book",
        "tags": [
            {
                "tag": "Jesus Christ",
                "type": 1
            },
            {
                "tag": "Art",
                "type": 1
            },
            {
                "tag": "Veronica",
                "type": 1
            },
            {
                "tag": "Art",
                "type": 1
            },
            {
                "tag": "Jesus Christ",
                "type": 1
            },
            {
                "tag": "Veronica",
                "type": 1
            },
            {
                "tag": "Veil of Veronica in art",
                "type": 1
            },
            {
                "tag": "Veil of Veronica in art",
                "type": 1
            },
            {
                "tag": "Art",
                "type": 1
            }
        ],
        "ISBN": [
            "978-80-210-8779-8"
        ],
        "title": "The European fortune of the Roman Veronica in the Middle Ages",
        "numPages": "303",
        "series": "Convivium (Brno, Czech Republic). Supplementum",
        "seriesNumber": "2017",
        "callNumber": "N8050 .E88 2017",
        "extra": "OCLC: on1021182894",
        "place": "Turnhout",
        "publisher": "Brepols",
        "date": "2017",
        "libraryCatalog": "Library of Congress ISBN",
        "accessDate": "2024-12-12",
        "editor": [
            [
                "Amanda C.",
                "Murphy"
            ],
            [
                "Herbert L.",
                "Kessler"
            ],
            [
                "Marco",
                "Petoletti"
            ],
            [
                "Eamon",
                "Duffy"
            ],
            [
                "Guido",
                "Milanese"
            ],
            [
                "Veronika",
                "Tvrzníková"
            ]
        ],
        "oclc": "on1021182894",
        "source": [
            "Zotero",
            "Library of Congress ISBN"
        ],
        "url": "https://www.worldcat.org/title/on1021182894"
    }
]

I've Implemented a quick fix which is not deployed yet.

The issue needs to be reported upstream (https://phabricator.wikimedia.org/project/view/62/) to see if it can be fixed there, I'll leave this open until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants