Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Protocol Specs] Manager Upgradeability section mixes motivation and requirement #33

Open
mmv08 opened this issue Aug 24, 2023 · 0 comments
Open

[Protocol Specs] Manager Upgradeability section mixes motivation and requirement #33

mmv08 opened this issue Aug 24, 2023 · 0 comments

Comments

@mmv08
Copy link
Member

mmv08 commented Aug 24, 2023

The section for Manager Upgradeability mixes requirements and motivation in a single paragraph. Judging by my experience with EIPs, separating the requirement and motivation is better.

Suggestion:

  • Clearly define the upgradeability requirement (MUST NOT be upgradeable, MUST LOAD information from previous' version manager, etc)
  • Put motivation in a separate paragraph
@rmeissner rmeissner self-assigned this Aug 28, 2023
@rmeissner rmeissner removed their assignment Sep 29, 2023
@rmeissner rmeissner changed the title nitpick: Manager Upgradeability section mixes motivation and requirement [Protocol Specs] Manager Upgradeability section mixes motivation and requirement Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmeissner @mmv08