Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core)!: Update the CRDs scheme #24

Closed
wants to merge 3 commits into from
Closed

feat(core)!: Update the CRDs scheme #24

wants to merge 3 commits into from

Conversation

anurag-rajawat
Copy link
Collaborator

Description

Fixes # (issue)

Does this PR introduce a breaking change?
Yes

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat anurag-rajawat marked this pull request as draft January 4, 2024 06:29
@anurag-rajawat anurag-rajawat deleted the intent-specs branch January 9, 2024 10:27
@anurag-rajawat anurag-rajawat restored the intent-specs branch January 9, 2024 10:27
@anurag-rajawat anurag-rajawat reopened this Jan 9, 2024
@seungsoo-lee
Copy link
Collaborator

@anurag-rajawat

please re-chcek

@anurag-rajawat
Copy link
Collaborator Author

Superseded by #35 PR, where you can find more details and the implemented solution. Closing this one.

@anurag-rajawat anurag-rajawat deleted the intent-specs branch January 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seungsoo-lee seungsoo-lee Awaiting requested review from seungsoo-lee

@shivaccuknox shivaccuknox Awaiting requested review from shivaccuknox

@rajaSahil rajaSahil Awaiting requested review from rajaSahil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anurag-rajawat @seungsoo-lee