Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nimbus): add fromSource field to network policy in SecurityIntent CRD #22

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

shivaccuknox
Copy link
Contributor

Description

Add the fromSource field to the network policy
Also, add short names for the securityIntent (sit) and securityIntentBinding (sib

uc2.txt
ksp2.txt

Fixes # (issue)

Does this PR introduce a breaking change?

Checklist

  • [*] PR title follows the <type>: <description> convention
  • [*] I use conventional commits in my commit messages
  • [*] I have updated the documentation accordingly
  • [*] I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • [*] I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

uc2.txt contains the yaml for the Security Intent, binding. The resultant ksp is shown in ksp2.txt

Mention if this PR is part of any design or a continuation of previous PRs

@shivaccuknox shivaccuknox merged commit 62ff799 into main Dec 20, 2023
5 checks passed
@shivaccuknox shivaccuknox deleted the shivkb/add-field-intent-crd branch December 21, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant