From 7728f4b469e72d5a3a48f60ecfe8e2588c1a701f Mon Sep 17 00:00:00 2001 From: Paul McHard Date: Mon, 13 May 2024 07:34:18 +0100 Subject: [PATCH] missing docs on docker command. --- Dockerfile | 2 +- README.md | 15 +++++++++++++++ regionDetection.py | 2 +- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 9c28625..a58b8b1 100644 --- a/Dockerfile +++ b/Dockerfile @@ -15,7 +15,7 @@ RUN pip install --upgrade pip && pip install -r requirements.txt COPY . . # Expose gRPC server port -EXPOSE 50051 +EXPOSE 500XX # Define the command to run the server CMD ["python", "regionDetection.py"] \ No newline at end of file diff --git a/README.md b/README.md index fe11680..b87337d 100644 --- a/README.md +++ b/README.md @@ -64,6 +64,21 @@ polylines, vertices = self.find_regions(image.copy(), min_edges=MIN_EDGES, preci We advise you to use the provided jupyter notebook to play with the region detection service with visual feedback to understand it. +Finally, in order to build your docker image, please update the gRPC Port to a number unique to you. For the purposes of this demonstration, please use the ROS Domain ID on your sign up sheet. Your port number needs to be updated in the following places: + +``` +- region_detection.py, line 26, PORT = 500XX, +- Dockerfile, line 18, EXPOSE 500XX +``` + +In both these cases, please update XX to your provided ROS Domain ID. + +Lastly, build your docker image using the command, providing a unique image name for your entry. + +```bash +docker build -t your-name-region-detector . +``` + Good luck and enjoy! Paul McHard \ No newline at end of file diff --git a/regionDetection.py b/regionDetection.py index a456ad9..bc1dce2 100644 --- a/regionDetection.py +++ b/regionDetection.py @@ -23,7 +23,7 @@ PRECISION = 0.01 THRESHOLD = 120 -PORT = 50051 +PORT = 500XX ALIAS = "Paul McHard" # End of Variables