Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler deploy of patch releases #371

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simpler deploy of patch releases #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
085de11
Use minor Tibanna version as AWSF image version
alexander-veit Sep 26, 2022
4472332
Fix docs-deploy
alexander-veit Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/main-deploy-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
# This workflow contains a single job called "build"
build:
# The type of runner that the job will run on
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
Expand All @@ -21,5 +21,6 @@ jobs:
- name: Docs
env:
DOCS_TOKEN: ${{ secrets.DOCS_TOKEN }}
TIBANNA_VERSION: 2.2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs-deploy GA does not work anymore. I think that's because it can't determine the version, since it is now parsed from pyproject.toml. One solution would be to set the env variable here. Not elegant at all, but I am not sure how to get it otherwise.
I had the same issue with the Lambda function and solved it there via env variables.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version won't matter for the docs build though right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version matters. It is also used in the conf.py in the docs folder.
image

run: curl -X POST -d "branches=master" -d "token=$DOCS_TOKEN" https://readthedocs.org/api/v2/webhook/tibanna/141616/

2 changes: 2 additions & 0 deletions docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ nose>=1.3
click>=6.6
git+https://github.com/golobor/sphinx-click
sphinx_rtd_theme
tomlkit>=0.10.0
semantic-version>=2.10.0
Loading