Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing from external sources - pagination fail #59

Open
floriangantner opened this issue Dec 11, 2023 · 0 comments · May be fixed by #62
Open

Importing from external sources - pagination fail #59

floriangantner opened this issue Dec 11, 2023 · 0 comments · May be fixed by #62
Labels

Comments

@floriangantner
Copy link

floriangantner commented Dec 11, 2023

When importing from external sources in DSpace-Cris (e.g. crossref or datacite) the pagination does not work.

To Reproduce
Steps to reproduce the behavior:

  1. Import something from some external source, e.g. datacite DOI 10.5281/zenodo with more than 10 results to be expect
  2. try to navigate between the results using the pagination
  3. the results list will keep the same, but the pagination (pages, number of changes) will change. There are no further requests when the pages change.

Expected behavior
We expect to paginate over external source entries . This works smooth on the standard DSpace Demo.

Thus we locate the problem at https://github.com/4Science/dspace-angular/blob/f5d618f093ce80506e49d799c0d4c6061586d598/src/app/submission/import-external/submission-import-external.component.ts#L119C6-L119C6
adding some this.searchConfigService.setPaginationId(this.initialPagination.id); to the init method will surely fix the problem, because the searchOptions requested when getting the external source entries returns the setting from the 'spc' configuration and not the uuid settings.

Related work
Link to any related tickets or PRs here.

@floriangantner floriangantner linked a pull request Dec 13, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant