Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search labels not translated #12

Open
floriangantner opened this issue Dec 9, 2022 · 0 comments · May be fixed by #13
Open

search labels not translated #12

floriangantner opened this issue Dec 9, 2022 · 0 comments · May be fixed by #13
Assignees
Labels

Comments

@floriangantner
Copy link

floriangantner commented Dec 9, 2022

Describe the bug
The applied search filter labels in the badges above the search results are not translated correctly.

To Reproduce

  1. apply some filter with known translation https://dspacecris7.4science.cloud/search?page=1&configuration=researchoutputs&query=&f.has_content_in_original_bundle=true,equals&spc.page=1
  2. switch to locale de
  3. in the badge "true" is displayed
    Screenshot 2022-12-09 at 09-47-13 DSpace Angular Suche

Expected behavior
3. We expect the existing values from the language json to be translated
4

// "search.filters.has_content_in_original_bundle.true": "Yes",

"search.filters.has_content_in_original_bundle.true": "Ja",

  "search.filters.has_content_in_original_bundle.true": "Ja",

Related work
PR will follow soon...
Either normalize the value and also replace ,equals
or
rename the keys to scheme:
search.filters.has_content_in_original_bundle,equals.true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants