Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for filtering encrypted field in list of values #136

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

m-przybylski
Copy link

I have implemented a fix for issue: #119.

Almost the same as PR: #120

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12089403065

Details

  • 6 of 10 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 78.469%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/encryption.ts 6 10 60.0%
Totals Coverage Status
Change from base Build 11485540163: -0.8%
Covered Lines: 273
Relevant Lines: 328

💛 - Coveralls

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/visitor.ts:53

  • [nitpick] The variable name 'value' is ambiguous. It should be renamed to 'specialSubFieldValue'.
const value: string = (node as any)[specialSubField]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants