Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatSweetMango
added
enhancement
4 tasks
yoouyeon
requested changes
Mar 6, 2024
izone00
reviewed
Mar 6, 2024
There was a problem hiding this comment.
리뷰는 아니고 단순 질문이 있어서 여기 코멘트를 달았습니다.
interface에 전부 I를 붙이셨는데
타입 관련해서 컨벤션 같은게 있는 건가요?
아니면 자유롭게 작성하는 건가요?
There was a problem hiding this comment.
현재 정의되어있는 컨벤션은없고 우선 관습적으로 I를 붙이고 있습니다. 근데 정말 I를 붙여야 하는지에 대해서는 생각을 좀 해봐야 할듯 하네요. IInterface와같이 인터페이스 인터페이스 같은 의미라 현재는 안붙이는 추세인듯 합니다.
|
#1265 과 동일한 내용의 PR입니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
지원 공고 등록 버튼 클릭시 지원공고 작성 페이지로 이동합니다.
TODO
✅ 변경로직