Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parksangmin1543
requested review from
yoouyeon,
greatSweetMango,
PHJoon and
hyobb109
3 tasks
yoouyeon
approved these changes
Apr 5, 2024
Comment on lines
+58
to
+59
| labelId='demo-multiple-checkbox-label' | ||
| id='demo-multiple-checkbox' |
There was a problem hiding this comment.
아이디에 demo 붙어 있는데, 임시로 조치한 부분이 아니면 제거하는 것이 좋을 것 같습니다.
| expandComponent: React.ReactNode; | ||
| } | ||
|
|
||
| const ExpandableTableRow: React.FC<ExpandableTableRowProps> = ({ |
There was a problem hiding this comment.
FC에는 기본적으로 optional children props가 있습니다. 따라서 위에 ExpandableTableRowProps에서 children을 재정의할 필요는 없었을 것 같아요. (옵셔널 -> 필수로 바꾸려던게 아니라면)
근데 위에 링크한 글처럼, React.FC에는 이것 말고도 여러 문제가 있어서 전반적으로 사용하지 말자는 것 같더라구요.
특별한 이유가 없다면 사용하지 않는 것이 좋을 것 같습니다.
| ...otherProps | ||
| }) => { | ||
| const [isExpanded, setIsExpanded] = useState(false); | ||
| const childrenCount = React.Children.count(children); |
There was a problem hiding this comment.
Children 사용하셨는데 https://react.dev/reference/react/Children 공식문서 보니까 레거시로 구분되어 있습니다. children을 만드는 부분을 보니 배열에 map을 돌리고 있는 것 같은데 React.Children.count 대신 props로 children 개수를 전달하는 방식으로 바꿀 수도 있을 것 같습니다.
hyobb109
reviewed
Apr 6, 2024
| setAnswers( | ||
| recruitUserData.reduce((acc, recruit) => { | ||
| recruit.form.forEach((formItem) => { | ||
| if (formItem.inputType !== 'TEXT') { |
hyobb109
reviewed
Apr 6, 2024
| <div className={styles.info}> | ||
| {(content?.toString() || '').slice(0, maxLen)}... | ||
| </div> | ||
| {/* <div className={`${styles.hoverInfo}`}>{content}</div> */} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
기본화면
상세보기
가로스크롤
객관식필터
멀티선택
객관식필터
✅ 변경로직